Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding platform for cross-compiling #20

Closed
wants to merge 1 commit into from

Conversation

ahdinosaur
Copy link
Contributor

No description provided.

@ralphtheninja
Copy link
Member

@ahdinosaur This screws with e.g. AppVeyor which defines PLATFORM as x64 https://ci.appveyor.com/project/Level/leveldown/builds/21742542/job/9c5xxhjn8inxbjma#L168 .. which means we will try to run node-gyp instead of node-gyp.cmd here https://github.com/ahdinosaur/prebuildify/blob/2e6da5d9f875c8d538806808924480607a5858da/index.js#L138

According to @vweevers it's used by MSVS

I propose we rename this to PREBUILD_PLATFORM instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants